[FLINK-1709] [wip] Add SlotCountExceedingParallelismTest#498
Closed
uce wants to merge 6 commits intoapache:masterfrom
Closed
[FLINK-1709] [wip] Add SlotCountExceedingParallelismTest#498uce wants to merge 6 commits intoapache:masterfrom
uce wants to merge 6 commits intoapache:masterfrom
Conversation
Contributor
|
The test looks good. One question: Why are you not simply using the The test-kit messages are IMHO mainly for testing the reaction of an actor to some isolated messages outside regular control flow. |
Contributor
Author
|
Regarding submission via |
Starting a task manager via TestingUtils does not respect the number of configured task managers and mis-configures the task managers to use local network communication (LocalConnectionManager instead of NettyConnectionManager).
uce
force-pushed
the
flink-1709-slot_dop
branch
from
ce7cbe6 to
9f25533
Compare
Contributor
Author
|
Changed the test accordingly and rebased. Can we merge this? |
Contributor
Author
|
Will squash and merge. :) |
mafernandez-stratio
pushed a commit
to mafernandez-stratio/flink
that referenced
this pull request
Mar 20, 2015
This commit squashes: - [jobmanager] Add subtask index to state transition debug msg - [jobmanager] Fix typo in ResultPartition deployment descriptor - [jobmanager] Fix missing queue scheduling mode This closes apache#498.
bhatsachin
pushed a commit
to bhatsachin/flink
that referenced
this pull request
May 5, 2015
This commit squashes: - [jobmanager] Add subtask index to state transition debug msg - [jobmanager] Fix typo in ResultPartition deployment descriptor - [jobmanager] Fix missing queue scheduling mode This closes apache#498.
marthavk
pushed a commit
to marthavk/flink
that referenced
this pull request
Jun 9, 2015
This commit squashes: - [jobmanager] Add subtask index to state transition debug msg - [jobmanager] Fix typo in ResultPartition deployment descriptor - [jobmanager] Fix missing queue scheduling mode This closes apache#498.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the initial simple case. I'll push the other variants to this branch.